[DOCS] Omit shard failures assertion for incompatible responses #31430
Conversation
|
Pinging @elastic/es-docs |
|
@elasticmachine test this please |
|
@nik9000 I pushed a second commit updating the regex to exclude API calls on an index such as |
|
So now that I look a little more closely, I think we want this for things like searches. So I think the name of the regex is wrong. It should match |
|
And also Yes it is a bit of a pickle and it's tricky to track as there isn't a single class for the response header I'm afraid we are creating a maintenance burden whitelisting known APIs perhaps we should simply exclude paths starting with |
I'd expluce |
davidkyle
force-pushed
the
docs-snippet-shard-assert
branch
from
6ab3498
to
539f057
Compare
davidkyle
changed the title
| @@ -47,4 +45,10 @@ class RestTestFromSnippetsTaskTest extends GroovyTestCase { | |||
| assertEquals("\"foo\": \"bort\\n baz\"", | |||
| replaceBlockQuote("\"foo\": \"\"\"bort\n baz\"\"\"")); | |||
| } | |||
|
|
|||
| void testIsDocWriteRequest() { | |||
There was a problem hiding this comment.
Can you change the name of the test?
Filter out the assertion for _cat and _xpack/ml/datafeed APIs
Filter out the assertion for _cat and _xpack/ml/datafeed APIs
* 6.x: [DOCS] Omit shard failures assertion for incompatible responses (#31430) [DOCS] Move licensing APIs to docs (#31445) backport of: add is-write-index flag to aliases (#30942) (#31412) backport of: Add rollover-creation-date setting to rolled over index (#31144) (#31413) [Docs] Extend Homebrew installation instructions (#28902) [Docs] Mention ip_range datatypes on ip type page (#31416) Multiplexing token filter (#31208) Fix use of time zone in date_histogram rewrite (#31407) Revert "Mute DefaultShardsIT#testDefaultShards test" [DOCS] Fixes code snippet testing for machine learning (#31189) Security: fix joining cluster with production license (#31341) [DOCS] Updated version in Info API example [DOCS] Moves the info API to docs (#31121) Revert "Increasing skip version for failing test on 6.x" Preserve response headers on cluster update task (#31421) [DOCS] Add code snippet testing for more ML APIs (#31404) Docs: Advice for reindexing many indices (#31279)
* master: [DOCS] Omit shard failures assertion for incompatible responses (#31430) [DOCS] Move licensing APIs to docs (#31445) Add Delete Snapshot High Level REST API Remove QueryCachingPolicy#ALWAYS_CACHE (#31451) [Docs] Extend Homebrew installation instructions (#28902) Choose JVM options ergonomically [Docs] Mention ip_range datatypes on ip type page (#31416) Multiplexing token filter (#31208) Fix use of time zone in date_histogram rewrite (#31407) Core: Remove index name resolver from base TransportAction (#31002) [DOCS] Fixes code snippet testing for machine learning (#31189) [DOCS] Removed and params from MLT. Closes #28128 (#31370) Security: fix joining cluster with production license (#31341) Unify http channels and exception handling (#31379) [DOCS] Moves the info API to docs (#31121) Preserve response headers on cluster update task (#31421) [DOCS] Add code snippet testing for more ML APIs (#31404) Do not preallocate bytes for channel buffer (#31400) Docs: Advice for reindexing many indices (#31279) Mute HttpExporterTests#testHttpExporterShutdown test Tracked by #31433 Docs: Add note about removing prepareExecute from the java client (#31401) Make release notes ignore the `>test-failure` label. (#31309)
The failures in the docs snippet testing seen in #31339 comment are due to the framework inserting the assertion
is_false: _shards.failureswhich causes errors if the response is not a JSON object.The ml datafeed preview API does not return a JSON object and is excluded from the check.